I generally like the new layout of the actions. But the (o) upload public key belongs in its own section parallel to the other "file this" items, and not in the reject category.
Thanks, Craig > On Feb 18, 2022, at 7:33 AM, sebb <seb...@gmail.com> wrote: > > On Fri, 18 Feb 2022 at 14:52, sebb <seb...@gmail.com> wrote: >> >> On Fri, 18 Feb 2022 at 03:25, Craig Russell <apache....@gmail.com> wrote: >>> >>> To recap: >>> >>> There are three possible resolutions for submitted documents: >>> defer: upload public key >>> file: valid document >>> reject: bad signature, missing stuff, not signed by officer, etc. >>> >>> This seems not to be reflected in the workflow... >> >> Having reverted to before the menu update, every single action now >> results in marking the email as deleted as part of the flow. >> >> AFAICT the handling of upload has always been wrong. > > Scrap that; mistake in testing. > upload does change the status, but does not delete the entry > >>> Craig >>> >>>> On Feb 17, 2022, at 5:49 PM, Craig Russell <apache....@gmail.com> wrote: >>>> >>>> The recent change to add more reject options seems to have broken the >>>> reject flow. >>>> >>>> Upload public key should not be in the reject tab because the file can >>>> still be processed. But other reasons in the reject tab should remove the >>>> item, and the accept icla should remove the item. >>>> >>>> Can you please review the logic to be sure it didn't change anything it >>>> should not? >>>> >>>> Thanks, >>>> Craig >>>> >>>> Craig L Russell >>>> c...@apache.org >>>> >>> >>> Craig L Russell >>> c...@apache.org >>> Craig L Russell c...@apache.org
