The icla code attempts [1] to rename PDF files to icla.pdf and icla.pdf.asc if there is a signature.
However the code has been broken for a while, because the fileext is nil unless the signature is empty [2]. Thus the condition becomes: if @signature.to_s.empty? or (not @signature.empty? && fileext != '.pdf') i.e. the condition is always true. AFAICT this has been the case since May 2017 [3] It's easy enough to fix (ensure fileext is always created). However I wonder if the rename is needed, and if so, why not rename other files that have detached signatures? Removing the rename would simplify the code, and make it easier to use the shared asvn_update task code. Note that most applications seem to use icla.pdf anyway. Sebb [1] https://github.com/apache/whimsy/blob/d714487b3da3f2efe7aed7021fa204eb22ba9cd5/www/secretary/workbench/views/actions/icla.json.rb#L68 [2] https://github.com/apache/whimsy/blob/d714487b3da3f2efe7aed7021fa204eb22ba9cd5/www/secretary/workbench/views/actions/icla.json.rb#L16 [3] https://github.com/apache/whimsy/commit/786413d74a2515f91916225d929705b7b5c08811
