This is the code in views/index.js.rb:
_tr row_options do
_td do
_a time, href: "#{message.href}", title: message.time
end
_td message.from
_td message.subject
end
From the web, the html code that opens the link in a new window would be
<a href="#{message.time}" target="_blank">"#{message.href}"</a>
But how does _a create a target= phrase?
Craig
> On Jul 16, 2020, at 3:30 PM, Craig Russell <apache....@gmail.com> wrote:
>
> Hi Sebb,
>
> Very Nice!!!
>
> I tried this out but was unable to make you Emeritus before you rescinded. ;-)
>
> Anyway, just one last thing. Can you make the link on the index page display
> as "open in new window" instead of replacing the current page?
>
> If Secretary wants to open in a new tab, there is a button for that (on most
> browsers). But the default should be to open in a new window.
>
> The reason is to allow secretary to simply close the roster/committer window
> when done with the emeritus request. As it is, closing the window will close
> the secretary workbench, which is awkward. And not closing the window
> requires secretary to back, back to get to the index page again.
>
> WDYT?
>
> Craig
>
>> Begin forwarded message:
>>
>> From: s...@apache.org <mailto:s...@apache.org>
>> Subject: [whimsy] branch master updated: Fix up time syntax
>> Date: July 16, 2020 at 3:00:59 PM PDT
>> To: "comm...@whimsical.apache.org <mailto:comm...@whimsical.apache.org>"
>> <comm...@whimsical.apache.org <mailto:comm...@whimsical.apache.org>>
>> Reply-To: dev@whimsical.apache.org <mailto:dev@whimsical.apache.org>
>>
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> sebb pushed a commit to branch master
>> in repository https://gitbox.apache.org/repos/asf/whimsy.git
>> <https://gitbox.apache.org/repos/asf/whimsy.git>
>>
>>
>> The following commit(s) were added to refs/heads/master by this push:
>> new 917979a Fix up time syntax
>> 917979a is described below
>>
>> commit 917979a237fb46bf4b281d527f23f8b3b3659c84
>> Author: Sebb <s...@apache.org <mailto:s...@apache.org>>
>> AuthorDate: Thu Jul 16 23:00:18 2020 +0100
>>
>> Fix up time syntax
>> ---
>> www/secretary/workbench/server.rb | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/www/secretary/workbench/server.rb
>> b/www/secretary/workbench/server.rb
>> index c1405e4..827225d 100644
>> --- a/www/secretary/workbench/server.rb
>> +++ b/www/secretary/workbench/server.rb
>> @@ -11,6 +11,7 @@ require 'ruby2js/filter/require'
>> require 'erb'
>> require 'sanitize'
>> require 'escape'
>> +require 'time' # for iso8601
>>
>> require_relative 'personalize'
>> require_relative 'helpers'
>> @@ -72,7 +73,7 @@ get '/' do
>> days = (((Time.now.to_i - epoch.to_i).to_f/SECS_TO_DAYS)).round(1)
>> id = File.basename(file,'.*')
>> @messages << {
>> - time: Time.at <http://time.at/>(epoch.to_i).to_s,
>> + time: Time.at <http://time.at/>(epoch.to_i).gmtime.iso8601,
>> href: "/roster/committer/#{id}",
>> from: ASF::Person.find(id).cn,
>> subject: "Pending emeritus request - #{days.to_s} days old",
>>
>
> Craig L Russell
> c...@apache.org <mailto:c...@apache.org>
>
Craig L Russell
c...@apache.org
