Thanks for the review. I have committed changes to the coi branch.
I'll wait a bit for others to weigh in as well. https://github.com/apache/whimsy/pull/98 > On Jun 23, 2020, at 4:57 PM, Sam Ruby <ru...@intertwingly.net> wrote: > > A quick scan of your last commit: > > + USER_AFFIRMATION_FILE = signerfile if stem == USERID > > The above line attempts to modify a constant. That will fail. I had not tested that, so good to know. > > + SIGNERS[stem] = signerfile unless stem == 'template' > > The above line is OK... modifying the contents of a hash doesn't > change the value of SIGNERS. > > .gsub("Signed: __", "Signed: __________#{name}___________") > - .gsub("Date: __", " Date: __________#{timestamp}______") > + .gsub("Date: __", "Date: __________#{timestamp}______") > > Depending on the length of the name, the above will result in > different length lines. I saw a different approach in the proxy.cgi but was not eager to put that complexity into this file. e.g. proxy[/authorize _(_{,#{@proxy.length}})/, 1] = @proxy.gsub(' ', '_') > > Consider using string.center: > > https://ruby-doc.org/core-2.4.0/String.html#method-i-center > > - Sam Ruby Craig L Russell c...@apache.org
