> On Jun 5, 2020, at 3:16 AM, sebb <seb...@gmail.com> wrote:
>
> On Fri, 5 Jun 2020 at 02:31, Sam Ruby <ru...@intertwingly.net> wrote:
>>
>> On Thu, Jun 4, 2020 at 9:11 PM Craig Russell <apache....@gmail.com> wrote:
>>>
>>> On branch master:
>>>
>>> I've tested my own profile but looking at others like psteitz it doesn't
>>> look like everything is working.
>>>
>>> I found my own emeritus-requests-received and it looks fine.
>>>
>>> But the display is wrong for psteitz. There should be a display for
>>> Emeritus Reinstated. I might have mixed up a "-" and "_" again.
>>>
>>> Can someone take a look?
>>
>> https://github.com/apache/whimsy/blob/694e96b80ca07251b14ca61fb5e46d8a4e4e9d6b/lib/whimsy/asf/documents.rb#L111
>>
>> At line 113, name is "phil-steitz"
>> At line 117, file is "phil-steitz-2012-05-24.txt"
I have since removed the date from the documents in emeritus-reinstated and in
emeritus-requests-received.
There is still the issue with the other request, which was filed using the full
name but which cannot be found by the EmeritusRequestFiles.find method.
>
> I think this can be solved once the format of the disambiguating
> suffix is agreed.
> The matching algorithm can then strip the suffix when doing matching.
>
> Alternatively, if duplicates are handled by using a directory, then
> the suffices only need to be added when adding a second document.
> In that case, the existing documents would need to have their suffixes
> removed.
IIRC this is the way the infrequent second ICLAs are handled, which I believe
is just fine.
>
> Whilst using a directory to handle further docs is more work if a
> subsequent document arrives, it does make it a bit easier to display
> the docs as the server automatically provides the directory listing.
>
> Maybe we should consider always using a directory per person?
I think limiting use of a directory to those cases that actually need it is a
good thing. Those cases: document with detached signature; second document of
the same type (change email address for ICLA; reinstate member for member_apps).
Craig
>
> There would still need to be a disambiguating suffix to handle
> duplicates, but that could be added when the document is first filed.
>
>>> Thanks,
>>> Craig
>>>
>>> Craig L Russell
>>> c...@apache.org
>>
>> - Sam Ruby
Craig L Russell
c...@apache.org
