On Mon, 13 Jan 2020 at 01:52, <ru...@apache.org> wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> rubys pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/whimsy.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
> new b34276b save the weakref
> b34276b is described below
>
> commit b34276b9018b4e5115dc2e30ac8d2ac073bdca42
> Author: Sam Ruby <ru...@intertwingly.net>
> AuthorDate: Sun Jan 12 20:51:48 2020 -0500
>
> save the weakref
> ---
> lib/whimsy/asf/ldap.rb | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/lib/whimsy/asf/ldap.rb b/lib/whimsy/asf/ldap.rb
> index f0e4969..8eba13a 100644
> --- a/lib/whimsy/asf/ldap.rb
> +++ b/lib/whimsy/asf/ldap.rb
> @@ -1161,7 +1161,7 @@ module ASF
> # list of committers on this project. Stored in LDAP as a
> <tt>member</tt>
> # attribute.
> def members
> - members = weakref(:members) do
> + self.members = weakref(:members) do
AFAICT that is unnecessary.
weakref(:members) writes @members
self.members= also writes @members
> ASF.search_one(base, "cn=#{name}", 'member').flatten
> end
>
> @@ -1170,7 +1170,7 @@ module ASF
>
> # list of member ids in the project
> def memberids
> - members = weakref(:members) do
> + self.members = weakref(:members) do
> ASF.search_one(base, "cn=#{name}", 'member').flatten
> end
> members.map {|uid| uid[/uid=(.*?),/,1]}
> @@ -1179,7 +1179,7 @@ module ASF
> # list of owners on this project. Stored in LDAP as a <tt>owners</tt>
> # attribute.
> def owners
> - owners = weakref(:owners) do
> + self.owners = weakref(:owners) do
> ASF.search_one(base, "cn=#{name}", 'owner').flatten
> end
>
> @@ -1188,7 +1188,7 @@ module ASF
>
> # list of owner ids in the project
> def ownerids
> - owners = weakref(:owners) do
> + self.owners = weakref(:owners) do
> ASF.search_one(base, "cn=#{name}", 'owner').flatten
> end
> owners.map {|uid| uid[/uid=(.*?),/,1]}
> @@ -1385,7 +1385,7 @@ module ASF
>
> # list of members for this service in LDAP
> def members
> - members = weakref(:members) do
> + self.members = weakref(:members) do
> ASF.search_one(base, "cn=#{name}", 'member').flatten
> end
>
> @@ -1394,7 +1394,7 @@ module ASF
>
> # list of memberids for this service in LDAP
> def memberids
> - members = weakref(:members) do
> + self.members = weakref(:members) do
> ASF.search_one(base, "cn=#{name}", 'member').flatten
> end
>
>
