On Wed, 1 May 2019 at 17:34, Sam Ruby <ru...@intertwingly.net> wrote:
>
> On Wed, May 1, 2019 at 12:05 PM sebb <seb...@gmail.com> wrote:
> >
> > https://github.com/apache/whimsy/blob/master/www/board/agenda/routes.rb#L129
> > says:
> >
> > next unless raw =~ /Subject: .*Board feedback on 2017-05-17 (.*) report/
> >
> > This looks like it was intended to be a variable date rather than
> > fixed in May 2017.
> >
> > Is it supposed to be #{date} instead?
>
> That's clearly a bug, and explains why the counts are all zero here:
>
> https://whimsy.apache.org/board/agenda/2019-04-17/followup.json
>
> I don't believe it needs to be a variable.  [-\d]+ would do just fine.

Surely that would match follow-ups for other meetings?
There should not be many as it only looks at dates since the meeting,
but there may be a few stragglers.

> > S
>
> - Sam Ruby
>
> P.S.  Neat trick to share.  Go to
> https://github.com/apache/whimsy/blob/master/www/board/agenda/routes.rb#L129.
> Type the letter 'y'.  Look at the URL.  It now is a stable one so the
> line number won't be wrong the next time somebody does a push.

Reply via email to