Sheng Wu wrote on 8/7/18 5:02 AM:
> After I try to change all the links from an image to text, the check of links 
> past. I am sure this is a check bug.
> 
> You can find the differences of link between http://skywalking.io and 
> http://skywalking.apache.org
> 
> The following HTML can't be verified by whimsical
> 
> <div class="team-member"> <h4><span class="navy">Sponsorship and 
> Donate</span> </h4> <p>Apache Software Foundation</p> <ul class="list-inline 
> social-icon"> <li><a href="http://www.apache.org/foundation/sponsorship.html"; 
> target="blank"><i class="fa fa-link"></i></a> </li> <!-- <li><a 
> href="mailto:";><i class="fa fa-envelope-o"></i></a> </li> --> </ul> </div>

Yes, the Whimsy site checker *requires* that there is a text component
to most links.  The code above displays "Sponsor..." as text, and then
separately displays the nice FontAwesome graphic as a link.

The short term fix is to make the change you did: ensure that an actual
text node of "Sponsor" or "Thanks" or whatever in the html is within an
<a ...> tag pointing to that link.  You could keep the nice graphics,
and have two links - one surrounding the text, and one surrounding the
graphic, if you wanted.

Remember: these checks aren't required until a project is about to
graduate to TLP, so you have time.

The long term fix is twofold:

- Better codifying what the required policy is, in terms of the specific
display on a website that matches the ASF's goals.  Having the word
"Sponsor" (in this case) be directly associated with the link is important.

- Improving the site-scan.rb code to detect any updated links allowable.

Relevant code to this specific case:

https://github.com/apache/whimsy/blob/master/lib/whimsy/sitestandards.rb#L87
https://github.com/apache/whimsy/blob/master/tools/site-scan.rb#L113


-- 

- Shane
  Whimsy PMC
  The Apache Software Foundation

Reply via email to