On 11 January 2018 at 03:03, Sam Ruby <ru...@intertwingly.net> wrote:
> On Wed, Jan 10, 2018 at 12:05 PM, Craig Russell <apache....@gmail.com> wrote:
>> tl;dr I'll push the below change to ldap.rb if no objections.
>
> If the change is to be made to the add/remove methods, there are 9
> sets of these:
>
> $ egrep 'def (add|remove)' ldap.rb
> def remove(people)
> def add(people)
> def remove(people)
> def remove_owners(people)
> def remove_members(people)
> def add(people)
> def add_owners(people)
> def add_members(people)
> def remove_owners(people)
> def remove_committers(people)
> def add_owners(people)
> def add_committers(people)
> def remove(people)
> def add(people)
> def remove(people)
> def add(people)
> def remove(people)
> def add(people)
>
> Alternately, there is only one ASF::LDAP.modify method. Perhaps
> replacing the first line of that method with the following two would
> suffice?
>
> list = list.rejectt {|mod| mod.mod_vals.empty?}
is that 'reject' or 'reject!' or ??
> ASF.ldap.modify(dn, list) unless list.empty?
>
> - Sam Ruby
