TL;DR I am still looking for a simplified column of radio buttons.
Thanks,
Craig
> On Dec 30, 2017, at 12:17 PM, Craig Russell <apache....@gmail.com> wrote:
>
> I've pushed changes to the project/icla and have some issues I just cannot
> figure out:
>
> 1. The discuss/vote/invite tab should default to discuss but instead defaults
> to invite but the display is for discuss.
Fixed.
@@ -99,7 +100,7 @@ class Invite < Vue
_li class: ('active' if @phase == :vote) do
_a 'Vote', onClick: self.selectVote
end
- _li class: ('active' if @phase = :invite) do <------------ OOPS
+ _li class: ('active' if @phase == :invite) do
_a 'Invite', onClick: self.selectInvite
end
end
> 2. The discuss/vote/invite tab responds to the mouse click by changing the
> form but doesn't change the discuss/vote/invite itself. It remains stuck on
> invite.
Fixed. See #1
> 3. The preview buttons never display even though the @phase variable is set
> to discuss, vote, or invite.
Fixed. See #1
> 4. The radio buttons are displayed vertically only because I added _p within
> them. I modeled these buttons after secretary/workbench selection which shows
> vertical but when I remove the _p the buttons are displayed horizontally all
> smooshed together.
Still looking for a simplifying fix here.
> 5. The Comment section is a text area but I cannot figure out how to make the
> width/size/columns stretch all the way across. I modeled the Note section of
> secretary/workbench but can't make a regular text box work with multiple
> lines.
Fixed with
- _textarea name: 'voteComment', value: @voteComment, rows: 4,
- placeholder: 'Please vote on this candidate.',
- onChange: self.setVoteComment
+ _textarea.form_control rows: 4,
+ placeholder: 'Please discuss this candidate',
+ name: 'voteBody', value: @voteBody,
+ onChange: self.setVoteBody
> 6. The Comment section would be nicer with a blue border.
Fixed. See #5
>
> Any suggestions? The code is in www/project/icla/views/pages/invite.js.rb
>
> Thanks,
>
> Craig
>
> Craig L Russell
> Secretary, Apache Software Foundation
> c...@apache.org http://db.apache.org/jdo
>
Craig L Russell
Secretary, Apache Software Foundation
c...@apache.org http://db.apache.org/jdo
