On 29 June 2017 at 19:47, <[email protected]> wrote: > This is an automated email from the ASF dual-hosted git repository. > > rubys pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/whimsy.git > > > The following commit(s) were added to refs/heads/master by this push: > new 8c2014d add pmc projects to list of committees > 8c2014d is described below > > commit 8c2014d4dc7be8fd838735024f397d248a3c3b6b > Author: Sam Ruby <[email protected]> > AuthorDate: Thu Jun 29 14:46:31 2017 -0400 > > add pmc projects to list of committees > --- > lib/whimsy/asf/ldap.rb | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/lib/whimsy/asf/ldap.rb b/lib/whimsy/asf/ldap.rb > index da45587..1a95330 100644 > --- a/lib/whimsy/asf/ldap.rb > +++ b/lib/whimsy/asf/ldap.rb > @@ -599,9 +599,19 @@ module ASF > > # list of LDAP committees that this individual is a member of > def committees > - weakref(:committees) do > + # legacy LDAP entries > + committees = weakref(:committees) do > Committee.list("member=uid=#{name},#{base}") > end > + > + # add in projects (currently only includes GUINEAPIGS) > + projects = self.projects.map(&:name) > + committees += ASF::Committee.pmcs.select do |pmc| > + projects.include? pmc.name > + end
I think that's wrong; it will include all projects regardless of whether the person is in the owner or member list. > + > + # dedup > + committees.uniq > end > > # list of LDAP projects that this individual is a member of > > -- > To stop receiving notification emails like this one, please contact > ['"[email protected]" <[email protected]>'].
