[ 
https://issues.apache.org/jira/browse/WHIMSY-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061495#comment-16061495
 ] 

Sebb commented on WHIMSY-109:
-----------------------------

Turns out it's trivial to do:

{code}
Open3.capture3(*%(git config --get remote.origin.url), {chdir: path})
{code}

However there are many more instances of Dir.chdir in the code - do they all 
need fixing, or is it not a problem?

> Code uses Dir.chdir and Dir.pwd without sync
> --------------------------------------------
>
>                 Key: WHIMSY-109
>                 URL: https://issues.apache.org/jira/browse/WHIMSY-109
>             Project: Whimsy
>          Issue Type: Bug
>            Reporter: Sebb
>            Assignee: Sebb
>
> The lib/whimsy code uses Dir.chdir in two places:
> asf/git.rb and svn.rb
> These are done under Mutex synchronisation.
> However AFAICT they use different instances of the Mutex.
> Also, there is an instance of Dir.pwd in the file asf/rack.rb
> This does not use a Mutex at all.
> So unless there is some other mutual exclusion occurring, there is a 
> potential for confusion over the actual working directory.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to