On 15 May 2017 at 13:07, <ru...@apache.org> wrote: > This is an automated email from the ASF dual-hosted git repository. > > rubys pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/whimsy.git > > The following commit(s) were added to refs/heads/master by this push: > new 44ca999 minor cleanup > 44ca999 is described below > > commit 44ca999a81559d83e4dfed2b9978e7c804e542b6 > Author: Sam Ruby <ru...@intertwingly.net> > AuthorDate: Mon May 15 08:04:27 2017 -0400 > > minor cleanup > --- > tools/site-scan.rb | 2 +- > www/site.cgi | 4 +--- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/tools/site-scan.rb b/tools/site-scan.rb > index 41ac380..bcc5fc1 100755 > --- a/tools/site-scan.rb > +++ b/tools/site-scan.rb > @@ -151,7 +151,7 @@ def parse(id, site, name) > doc.css('a').each do |a| > > # check the link targets > - a_href = a['href'] ? a['href'].strip : '' # empty string won't match and > won't cause NPE > + a_href = a['href'].to_s.strip > > if a_href =~ %r{^https?://(www\.)?apache\.org/?$} > img = a.at('img') > diff --git a/www/site.cgi b/www/site.cgi > index 8d32ff8..daf0092 100755 > --- a/www/site.cgi > +++ b/www/site.cgi > @@ -10,8 +10,7 @@ end > > $LOAD_PATH.unshift File.realpath(File.expand_path('../../lib', __FILE__)) > require 'json' > -# needed for _whimsy_header/footer > -require 'whimsy/asf' > +require 'whimsy/asf/themes' > require 'wunderbar' > require 'wunderbar/bootstrap' > require 'wunderbar/jquery/stupidtable' > @@ -54,7 +53,6 @@ def analyze(sites) > ] > end > > -# n = project name
Why drop that comment? It's not obvious to me what the parameter 'n' represents. 'c' is not particularly obvious either... > def label(analysis, links, c, n) > if not links[c] > 'label-danger' > > -- > To stop receiving notification emails like this one, please contact > ['"comm...@whimsical.apache.org" <comm...@whimsical.apache.org>'].