On Fri, May 12, 2017 at 6:51 PM, Craig Russell <apache....@gmail.com> wrote: > > I know up front that this is a second icla. So good idea for this to be a > different action. > (O) icla > (O) additional icla > (O) ccla > > Full Name: this is the key to find the entry in iclas.txt > Public Name: this should replace the public name in the entry > email: this should replace the email in the entry > file name: this is generated from Full Name and is the directory for the iclas > > If a third icla comes in, I can handle this manually. Unless it's easy to put > in now: > > if full-name/full-name.pdf (or full-name/icla.pdf and icla.pdf.asc) already > exists: > find the largest n in full-name/full-name<n>.pdf > file the new icla under full-name/full-name<n+1>.pdf > > and replace Public Name and email in iclas.txt as for the second one.
Handling the 'nth' case doesn't concern me. What does concern me is the ability to change the Full Name (and therefore the filename). If you do that, this won't be a second ICLA, and the code won't be able to identify an existing line in iclas.txt to update. I'd like to suggest as an alternative, two fields: one identifying the existing user, and one identifying the new email address. This should handle the bulk of the additional icla requests. Anything else can be done manually? - Sam Ruby
