On 17 April 2017 at 18:29, Craig Russell <[email protected]> wrote: > Workflow: > > Secretary determines that a replacement icla is not coming. > > Secretary requests infra to disable the account. > > Infra disables the account. How does whimsy know that the account is disabled?
Generally the shell is set to an invalid exe, or .../false. See the 'banned?' function: https://github.com/apache/whimsy/blob/master/lib/whimsy/asf/ldap.rb#L525 Perhaps we should rename the function/give it a better alias? > Secretary updates iclas.txt with "disabled; no icla on file" > > The icla-lint should be able to reconcile disabled account in LDAP with > disabled account in iclas.txt. > > How should whimsy committer display disabled accounts? Whimsy does not currently display the disabled flag. However it is added to https://whimsy.apache.org/public/public_ldap_people.json as the boolean attribute 'noLogin', and phoneBook uses that. Probably Whimsy should use it too. > Should there be a date stamp when the account was disabled? That might be tricky to implement. <snip>
