On Fri, Mar 4, 2016 at 6:52 PM, sebb <seb...@gmail.com> wrote: > On 4 March 2016 at 23:35, Sam Ruby <ru...@intertwingly.net> wrote: >> On Fri, Mar 4, 2016 at 6:03 PM, sebb <seb...@gmail.com> wrote: >>> On 4 March 2016 at 22:11, Sam Ruby <ru...@apache.org> wrote: >>>> Commit 8e4446b542c6a69f2d754e4e53ced1860e82617b: >>>> disable SMTP certificate verification >>> >>> Why? >> >> The root cause is the procmail isn't configured with a proper certificate: >> >> https://github.com/apache/infrastructure-puppet/commit/e0ac1e61706e5651f6ea2c00549f9a5fc1d16b4c >> >>> This should be documented in the code. >> >> Unless it is fixed properly (which I'm not sure is worth it?), this >> applies to every bit of code that will be sending email from whimsy. >> Other locations where this code currently appears (and appeared on the >> previous whimsy-vm): >> >> www/board/agenda/views/actions/feedback.json.rb >> www/board/agenda/views/actions/send-reminders.json.rb >> >> As the number of places where email will be sent is only likely to go >> up over time, perhaps the right place to document in one of the *.md >> files in the root directory? > > An alternative would be to extract the e-mail code into a library routine. > This would simplify updates and make it easier to mock it for testing.
Excellent suggestion. Done: https://github.com/apache/whimsy/commit/c407730a9c0babdc34200be691470b7b63937be5 - Sam Ruby
