Cool!  This is the type of feedback I've been looking for!

More inline.

On Tue, Jan 5, 2016 at 5:06 PM, Craig L Russell
<craig.russ...@oracle.com> wrote:
> 1. When a message is selected, only the from:, to:, and subject: fields are 
> displayed. The text of the message is not visible. This appears to be just in 
> some cases, e.g. 2016-01-05T18:24:03Z and 2016-01-05T17:52:10Z .

That was indeed a bug.  Fixed.

> 2. The left frame doesn't size correctly. It initially displays with a scroll 
> bar at the bottom. If the vertical bar separating the data entry from the 
> display is moved, the scroll bar still shows and the last few pixels in the 
> fields are not visible.

Odd.  I don't see this with Safari, Firefox, or Chrome, all on a Mac.
Can you tell me what browser you are using, and perhaps send a screen
capture?

> 3. When File is pushed, 90 seconds later the alert comes up "stub for ICLA, 
> filename: chaudhary--sunaina". Is it supposed to take over a minute to svn 
> add  /Users/clr/apache/documents/iclas/chaudhary--sunaina.pdf?

What's happening here is:

1) cleanup/revert of any partial commits that may have failed.
2) svn updates to retrieve the latest copy of both foundation/officers
and documents/iclas
3) svn add of the relevant document.

Only #2 above should take a noticeable amount of time, particularly if
you haven't updated recently.  On my machine, I'm seeing a total of 5
to 6 seconds average for the whole operation.  Hopefully we should see
comparable or better times when this is deployed on whimsy-test.

I may be able to eliminate one svn update.  Of course, svn commit and
email need to be added, which will add to the elapsed time.  Overall,
this should be no worse than the current workbench, and actually
should be a half-second or so per server interaction better.  Note
that NOT displaying the svn commands as they are being executed
reduces the number of server interactions.

> 4. When doing File a second time with the same document name, there is no 
> error that there is already a document by that name. Only when I tried to svn 
> rm the document did it give me the error. There is an error when doing a File 
> with a document that is already in the repository.

The previous (incomplete) commit is cleaned up first.

> 5. I'd prefer the cursor to change to a "wait for response" instead of the 
> slowly rotating clock.

OK, done.

> 6. It's not clear from the layout of the panel whether the pmc and podling 
> fields are effective with the File button. Perhaps pmc and podling fields 
> should be above the File button?

The file button only updates iclas.txt and placed the pdf into
documents/iclas.  The pmc and podling fields are only used for new
account requests.

> 7. The flow with the current tool is to fill all the fields, File, Commit, 
> and then request account. What is the intent of the Request Account button on 
> this screen?

The proposed new flow is File (which will do a commit) then Request
Account (which is now a button).

> 8. In the current tool, File brings up the svn commands that can be double 
> checked for errors. The new tool should do something similar. There is an 
> alert if there is a problem with an svn command but the current tool has a 
> better way to present the problem, with the svn commands and then an alert to 
> ask whether it should continue.

I'll look at that in a subsequent pass.

> 9. When filing a document with a digital signature, error: Exception: 
> #<IOError: invalid filename: duncan-godwin>. It should be 
> duncan-godwin/icla.txt and icla.txt.asc. But then I tried again and this 
> time, success: stub for ICLA, filename: duncan-godwin. But sadly, only the 
> .asc file was added.

The first is a bug, and has been fixed.

The second (only filing the .asc) may have occurred if you had
selected the asc file separately.  To prevent this, I've now committed
a change which will no longer prompt you for the document type of
files ending in .asc or .sig.

> 10. There should be a button to return to the main screen.

Suggestion for where the button should go?  Meanwhile, up arrow will
return you to the main screen.

> 11. The drag/drop of .jpg files doesn't appear to work. It should also 
> display the convert commands that are being executed. And there doesn't 
> appear to be an "undo" in case the drag/drop order was wrong. Drag/drop of 
> pdf files works as expected.

What problem are you seeing?  If I go to "2015-12-19T17:50:43Z" and
drag "IMG_1119.JPG" and drop it on "IMG_1118.JPG", I get
"IMG_1118.png".

Where should the convert commands be displayed?  At the moment, the
right pane will typically show the contents of the file being dragged
before the drop is complete, and will show the contents of the
combined file afterwards.

A "right click" should bring up a menu that will burst a PDF.

> 12. Once a mail has been processed, what should be the indication on the main 
> page? How do I tell that there is new work to do?

Like with the current secretary workbench, the idea is that once a
document is filed or deleted it will no longer show up in the main
index.

That may mean that with emails such as "2016-01-05T10:54:59Z", you
will need to file the ICLA and then delete the rest (either
individually via the context menu or collectively using
command-delete).

> Good progress.

Thanks!

> Craig
>
> Craig L Russell
> Architect, Oracle
> http://db.apache.org/jdo
> 408 276-5638 mailto:craig.russ...@oracle.com
> P.S. A good JDO? O, Gasp!

- Sam Ruby

Reply via email to