> Well I mean this is awesome to have MSC, but is there any way we could > potentially split the PR to certain reviewable size?
let me think of that. Maybe split it into some small parts as following: M0.1: Passes for set name and layout for expressions (src/contrib/msc/transform) M0.2: MSCGraph core (src/contrib/msc/core/ir/graph && python/tvm/contrib/msc/core/ir/graph) M0.3: MSCGraph Builder (src/contrib/msc/core/ir/graph_builder) M0.4: Codegen (src/contrib/msc/core/codegen, src/contrib/msc/framework/tvm/codegen) M0.5: Test (tests/python/contrib/test_msc && related helper modules in python) Each step is functional isolated and play as pre-request of next step. I can try add some test after each part. -- Reply to this email directly or view it on GitHub: https://github.com/apache/tvm/pull/15489#issuecomment-1666443937 You are receiving this because you are subscribed to this thread. Message ID: <apache/tvm/pull/15489/c1666443...@github.com>
