I think this is a good idea.  In my opinion it would be authors' responsibility 
not to abuse the new ability: the merge directive should be added only once the 
PR has reached an agreement.  That is a subjective judgment, but it would be 
hard to codify it.

One question---what should happen if (1) PR is approved and looks 
non-controvesial, (2) author adds a merge directive, and then (3) some other 
reviewer requests changes?  Should we expect the merge directive to be 
canceled?  I think we should consider what is actually possible to implement in 
automation, maybe there is no way to handle this scenario.





---
[Visit 
Topic](https://discuss.tvm.apache.org/t/rfc-allow-merging-via-pr-comments/12220/5)
 to respond.

You are receiving this because you enabled mailing list mode.

To unsubscribe from these emails, [click 
here](https://discuss.tvm.apache.org/email/unsubscribe/7978914dd3eb5071717f2b42c4c53889d6661748afe767b007386ee70eb639da).

Reply via email to