Hi @kparzysz ,
Sorry to hear that there was downstream failure because of #8509. [quote="kparzysz, post:1, topic:12165"] Float16 constants are not supported by constants in TIR and compilation aborts. [/quote] [quote="kparzysz, post:1, topic:12165"] Constants that are not parameters cannot have type float16, because that type is not supported by current TIR code (for embedded constants). If this extraction doesn’t happen, compilation will abort if a float16 constant is found in TIR. [/quote] [quote="masahi, post:3, topic:12165"] I wonder why TIR constants doesn’t support fp16? Because of the need for c-codegen? [/quote] I am also wondering how this is true, because of the following (note that we just used what was supported in TVM via LinkedParam node) : https://github.com/apache/tvm/blob/dcbdeddba290caee4f604e678a7e315aea038881/src/target/llvm/codegen_params.cc#L137-L157 https://github.com/apache/tvm/blob/dcbdeddba290caee4f604e678a7e315aea038881/src/target/source/codegen_params.cc#L214-L229 The above are called respectively in the following locations : https://github.com/apache/tvm/blob/dcbdeddba290caee4f604e678a7e315aea038881/src/target/llvm/codegen_llvm.cc#L1485 https://github.com/apache/tvm/blob/dcbdeddba290caee4f604e678a7e315aea038881/src/target/source/codegen_c.cc#L673 [quote="kparzysz, post:1, topic:12165"] This can be, at least in theory, overridden by pass context flag `relay.FuseOps.link_params`, but there is an issue. [/quote] [quote="kparzysz, post:1, topic:12165"] It seems like `FuseOps` should be getting settings consistent with the CPU target that `FoldConstants` created, instead of using `Executor` from `IRModule`. This difference may have further consequences if passes executed during `FoldConstants` consult the executor for more information. [/quote] I think we need to move the link-params to be a property of the TIR backend (i.e. target). We need to fix this if it is not happenning. @kparzysz would you be able to file an issue ? attn : @dmitriy-arm @Mousius However, the above seems to be the workaround of the issue, the real issue I suspect is hexagon backend expect LinkedParams if --link-params is used, however, there is not a unit test (a simple codegen one) to assert this -- that should have been broken by #8509. --- [Visit Topic](https://discuss.tvm.apache.org/t/problem-with-fuseops-and-embedded-constants-in-tir/12165/5) to respond. You are receiving this because you enabled mailing list mode. To unsubscribe from these emails, [click here](https://discuss.tvm.apache.org/email/unsubscribe/9a9ea5258496cff4bd8d18f61d8667397cdf37126ff595badae99321beb4cee2).
