In many places having a global pytest flag is useful . For me with the
build and test of tvm , I would like to be able to globally pass in
pytest options as part of development flow or CI flows where one would
like to measure other things regularly that need measurements including
pytest coverage data that I would like to experiment with across the stack.
This has been achieved with an additional setup-pytest-env.sh file in
tests/scripts rather than putting in something in every single task test
script and something I would like to avoid.
This now means the -v option to pytest is superfluous. I did consider
having a pytest.ini file but that doesn't allow me to pass any old
environment variable in and this seems to be the best compromise.
I have also updated the pull request documentation to reflect
the presence of the -k pytest option at the same time though
technically this could be a separate pull request.
@tqchen
You can view, comment on, or merge this pull request online at:
https://github.com/apache/incubator-tvm/pull/5421
-- Commit Summary --
* [RFC] Pass pytest options globally.
* Improve other use case documentation
-- File Changes --
M docker/bash.sh (1)
M docker/build.sh (1)
M docker/with_the_same_user (2)
M docs/contribute/pull_request.rst (3)
A tests/scripts/setup-pytest-env.sh (21)
M tests/scripts/task_python_frontend.sh (18)
M tests/scripts/task_python_integration.sh (18)
M tests/scripts/task_python_nightly.sh (2)
M tests/scripts/task_python_topi.sh (2)
M tests/scripts/task_python_unittest.sh (4)
M tests/scripts/task_python_vta_fsim.sh (4)
M tests/scripts/task_python_vta_tsim.sh (4)
-- Patch Links --
https://github.com/apache/incubator-tvm/pull/5421.patch
https://github.com/apache/incubator-tvm/pull/5421.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-tvm/pull/5421
