Sounds great. As always, thank you for the good feedback. I've updated the PR with these changes. (Removed Set, updated Add to take a comma list, added Remove support).
On Wed, Sep 3, 2025 at 11:03 AM Leif Hedstrom <[email protected]> wrote: > > > > On Aug 29, 2025, at 12:30 PM, Brian Neradt <[email protected]> > wrote: > > > > Hi [email protected], > > > > I have a PR up to add an exempt list of IPs for: > > > https://docs.trafficserver.apache.org/en/latest/admin-guide/files/records.yaml.en.html#proxy-config-net-per-client-max-connections-in > > > > The new records.yaml value is > > proxy.config.http.per_client.connection.exempt_list which takes a > > comma-separated string of IP ranges for which the connection limit does > not > > apply. This could be helpful for hosts in an organization's network for > > which the limit should not apply, for instance. > > > > While working on that, it was suggested that we add a plugin API to > > manipulate the list. The API I propose is: > > > > TSConnectionLimitExemptListSet > > TSConnectionLimitExemptListAdd > > TSConnectionLimitExemptListClear > > > So I think this is generally good, but, I would personally change this > slightly, for SRP: > > 1. Remove TSConnectionLimitExemptListSet() (it’s a convenience over > Clear() + add()) > 2. Add a TSConnectionLimitExemptListRemove() > > As such, you would need to allow Add() to take one, or a list, of IP > ranges in the string_view. And I’d suggest Remove() follows that guidelines > as well. > > Cheers, > > — leif > > > > > PR that documents and implements the API: > > https://github.com/apache/trafficserver/pull/12198 > > > > PR that adds a cript to set the API from a YAML file: > > https://github.com/apache/trafficserver/pull/12476 > > > > Please let me know whether you have any thoughts or concerns. > > > > Thank you! > > Brian Neradt > > -- > > "Come to Me, all who are weary and heavy-laden, and I will > > give you rest. Take My yoke upon you and learn from Me, for > > I am gentle and humble in heart, and you will find rest for > > your souls. For My yoke is easy and My burden is light." > > > > ~ Matthew 11:28-30 > > -- "Come to Me, all who are weary and heavy-laden, and I will give you rest. Take My yoke upon you and learn from Me, for I am gentle and humble in heart, and you will find rest for your souls. For My yoke is easy and My burden is light." ~ Matthew 11:28-30
