I kept the new API in experimental.h for now, because even existing TSHttpTxnInfoIntGet is currently in experimental.h and I think we probably want to have the Ssn version (new one) next to it.
-- Masakazu On Wed, Oct 25, 2023 at 3:19 PM Leif Hedstrom <zw...@apache.org> wrote: > +1 > > As for experimental, I think we mostly decided to stop using this. In fact > we should remove / move what’s left there IMO. > > — Leif > > > On Oct 25, 2023, at 14:10, Masakazu Kitajo <m4s...@gmail.com> wrote: > > > > Hi, > > > > I'd like to add TSHttpSsnInfoIntGet to TS API. The API documentation is > on > > the PR below: > > https://github.com/apache/trafficserver/pull/10627 > > > > We currently have a similar function, TSHttpTxnInfoIntGet, for > > transactions, and the new API would be one for sessions. The function > > signature is basically the same as the one for transactions but it > receives > > values for sessions. And I added an optional parameter, sub_key, for > extra > > flexibility. > > > > I feel like we had some discussion about experimental.h but I don't > > remember the details. Are we going to remove it, or was that we just > wanted > > to do cleanup? I put the new API into experimental.h because I'm not too > > sure if the sub_key fits well for other use cases of the API. > > > > Thanks, > > Masakazu >
