Re: What happened with experimental-linux-io-uring?

[Randy DuCharme]

Greetings,




Best!!


On 9/19/23 14:10, Chris McFarlen wrote:

Thanks a bunch!  I got started looking into it but was swiftly derailed..... :/   Trying to find work and that takes priority.....

Hi Randy!

This is a recent regression. I'll fix this up. Thanks for reporting this!

Chris

Sent with [Proton Mail](https://proton.me/) secure email.

------- Original Message -------
On Tuesday, September 19th, 2023 at 6:45 AM, Randy DuCharme 
<radio.ad...@gmail.com> wrote:

Greetings all,

I've used linux-io-uring without issue since it was introduced. (I seldom build 
anything but master) Now it doesn't like to build:

make[2]: Entering directory 
'/export/home/randy/Projects/Apache/ats-build/iocore/io_uring'
CXX IOUringEventIO.o
CXX io_uring.o
../../../trafficserver/iocore/io_uring/io_uring.cc:131:3: error: use of 
undeclared identifier 'Metrics'
Metrics::increment(aio_rsb.io_uring_submitted, io_uring_submit(&ring));
^
../../../trafficserver/iocore/io_uring/io_uring.cc:131:22: error: use of 
undeclared identifier 'aio_rsb'
Metrics::increment(aio_rsb.io_uring_submitted, io_uring_submit(&ring));
^
../../../trafficserver/iocore/io_uring/io_uring.cc:149:5: error: use of 
undeclared identifier 'Metrics'
Metrics::increment(aio_rsb.io_uring_completed);
^
../../../trafficserver/iocore/io_uring/io_uring.cc:149:24: error: use of 
undeclared identifier 'aio_rsb'
Metrics::increment(aio_rsb.io_uring_completed);
^
../../../trafficserver/iocore/io_uring/io_uring.cc:171:3: error: use of 
undeclared identifier 'Metrics'
Metrics::increment(aio_rsb.io_uring_submitted, count);
^
../../../trafficserver/iocore/io_uring/io_uring.cc:171:22: error: use of 
undeclared identifier 'aio_rsb'
Metrics::increment(aio_rsb.io_uring_submitted, count);
^
../../../trafficserver/iocore/io_uring/io_uring.cc:174:5: error: use of 
undeclared identifier 'Metrics'
Metrics::increment(aio_rsb.io_uring_completed);
^
../../../trafficserver/iocore/io_uring/io_uring.cc:174:24: error: use of 
undeclared identifier 'aio_rsb'
Metrics::increment(aio_rsb.io_uring_completed);
^
8 errors generated.
make[2]: *** [Makefile:692: io_uring.o] Error 1
make[2]: Leaving directory 
'/export/home/randy/Projects/Apache/ats-build/iocore/io_uring'
make[1]: *** [Makefile:604: all-recursive] Error 1
make[1]: Leaving directory '/export/home/randy/Projects/Apache/ats-build/iocore'
make: *** [Makefile:895: all-recursive] Error 1

I'll roll up my sleeves and see what I can find. I have no doubt however that 
you regular devs and maintainers will have a solution/answer well before I get 
my dev environment powered up.

Kind regards!

--
Randall DuCharme (Radio AD5GB)
Powered entirely by Open Source software.

--
Randall DuCharme (Radio AD5GB)
Powered entirely by Open Source software.

OpenPGP_0x4BC19D71C1381AA3.asc
Description: OpenPGP public key

OpenPGP_signature
Description: OpenPGP digital signature