On 9/11/23 17:07, Brian Neradt wrote:
Hi jean-frederic clere,
I believe these have been addressed in master already:
https://github.com/apache/trafficserver/pull/9586
(Note that the description points to the libswoc change for the TextView
issue you mentioned.)
When using master I had to fix:
+++
diff --git a/tests/gold_tests/chunked_encoding/Makefile.inc
b/tests/gold_tests/chunked_encoding/Makefile.inc
index b316b4b41..96e05d8b4 100644
--- a/tests/gold_tests/chunked_encoding/Makefile.inc
+++ b/tests/gold_tests/chunked_encoding/Makefile.inc
@@ -16,4 +16,4 @@
noinst_PROGRAMS += gold_tests/chunked_encoding/smuggle-client
gold_tests_chunked_encoding_smuggle_client_SOURCES =
gold_tests/chunked_encoding/smuggle-client.c
-gold_tests_chunked_encoding_smuggle_client_LDADD = -lssl
+gold_tests_chunked_encoding_smuggle_client_LDADD = -lssl -lcrypto
+++
I am trying QUIC, but I am stuck trying to find what to use, quiche +
boringssl doesn't seem to help to build a QUIC enabled TS, is there an
up to date doc somewhere?
On Mon, Sep 11, 2023 at 10:07 AM Walt Karas <wka...@yahooinc.com.invalid>
wrote:
On the master branch, cstdint is already included:
https://github.com/apache/trafficserver/blob/master/lib/swoc/include/swoc/TextView.h
On Mon, Sep 11, 2023 at 10:30 AM jean-frederic clere <jfcl...@gmail.com>
wrote:
On 9/11/23 15:59, jean-frederic clere wrote:
On 9/11/23 15:40, jean-frederic clere wrote:
Hi,
I have:
+++
jfclere@dhcp-144-162 swoc]$ make
CXX src/bw_ip_format.lo
In file included from
/home/jfclere/trafficserver/lib/swoc/include/swoc/swoc_ip.h:16,
from src/bw_ip_format.cc:8:
/home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:892:1:
error: 'intmax_t' does not name a type; did you mean 'int8_t'?
892 | intmax_t svtoi(TextView src, TextView *parsed = nullptr, int
base = 0);
| ^~~~~~~~
| int8_t
/home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:904:1:
error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
904 | uintmax_t svtou(TextView src, TextView *parsed = nullptr, int
base = 0);
| ^~~~~~~~~
| uint8_t
/home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:922:1:
error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
922 | uintmax_t
| ^~~~~~~~~
| uint8_t
/home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:944:1:
error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
944 | uintmax_t
| ^~~~~~~~~
| uint8_t
make: *** [Makefile:783: src/bw_ip_format.lo] Error 1
+++
I am sure I am making something wrong... Any hints?
The fix looks to be:
+++
[jfclere@fedora trafficserver]$ git diff .
diff --git a/lib/swoc/include/swoc/TextView.h
b/lib/swoc/include/swoc/TextView.h
index e1537416f..897fd7968 100644
--- a/lib/swoc/include/swoc/TextView.h
+++ b/lib/swoc/include/swoc/TextView.h
@@ -18,6 +18,7 @@
#include <string>
#include <string_view>
#include <limits>
+#include <stdint.h>
#include "swoc/swoc_version.h"
#include "swoc/string_view_util.h"
+++
I am on fedora38.
Oops I think the same applies to:
+++
diff --git a/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
b/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
index 526199d8d..9d0394cc7 100644
--- a/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
+++ b/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
@@ -22,6 +22,7 @@
#include <vector>
#include <cstdlib>
#include <atomic>
+#include <cstdint>
#include <unistd.h>
#include <sys/socket.h>
+++
--
Cheers
Jean-Frederic
--
Cheers
Jean-Frederic
