Greetings,This fixes a build that breaks a build on an oddball ARM device (ODroid XU-4). It's a 32bit device/build. It builds fine without the patch on OpenSuSE Tumbleweed, Fedora 35 and CentOS Stream 64 bit systems. (It also builds with it) Should I bother with the PR?
diff --git a/proxy/logging/LogUtils.cc b/proxy/logging/LogUtils.cc index e15767410..25fe6728a 100644 --- a/proxy/logging/LogUtils.cc +++ b/proxy/logging/LogUtils.cc@@ -599,7 +599,7 @@ LogUtils::file_is_writeable(const char *full_filename, off_t *size_bytes, bool *
if (e < 0) {
ret_val = -1;
} else {
- if (limit_data.rlim_cur != static_cast<rlim_t> RLIM_INFINITY) {
+ if (limit_data.rlim_cur != static_cast<rlim_t>(RLIM_INFINITY)) {
if (has_size_limit) {
*has_size_limit = true;
}
Again, it's an odd device. Not even sure why I tried to build ATS on it :-/
The ArchArmLinux distro ships with GCC 10.2.0
Running lscpu looks like this:
Architecture: armv7l
Byte Order: Little Endian
CPU(s): 8
On-line CPU(s) list: 0-7
Vendor ID: ARM
Model name: Cortex-A7
Model: 3
Thread(s) per core: 1
Core(s) per socket: 4
Socket(s): 1
Stepping: r0p3
CPU max MHz: 1500.0000
CPU min MHz: 200.0000
BogoMIPS: 120.00
Flags: half thumb fastmult vfp edsp neon vfpv3 tls
vfpv4 idiva idivt vfpd32 lpae
Model name: Cortex-A15 Model: 3 Thread(s) per core: 1 Core(s) per socket: 4 Socket(s): 1 Stepping: r2p3 CPU max MHz: 2000.0000 CPU min MHz: 200.0000 BogoMIPS: 120.00Flags: half thumb fastmult vfp edsp neon vfpv3 tls vfpv4 idiva idivt vfpd32 lpae
[randy@odroid trafficserver]$ -- Randall DuCharme (Radio AD5GB) Powered entirely by Open Source software.
OpenPGP_0x4BC19D71C1381AA3.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
