Okay - I'll get one going... On 8/21/2021 10:13 AM, Alan Carroll wrote:
Best to just put up a PR. It's ok if the PR is small.On Sat, Aug 21, 2021 at 8:57 AM Randy DuCharme <ra...@ad5gb.com.invalid> wrote:Hey all, Seems like the latest fetch from master is missing that include directive in *trafficserver/plugins/experimental/traffic_dump/session_data.h*. Has anyone got anything going they can slide this into or should I create a PR? CXX experimental/tls_bridge/regex.lo CC experimental/url_sig/url_sig.lo In file included from ../../trafficserver/plugins/experimental/traffic_dump/traffic_dump.cc:29: ../../trafficserver/plugins/experimental/traffic_dump/session_data.h:110:15: error: ‘optional’ in namespace ‘std’ does not name a template type 110 | static std::optional<IpAddr> client_ip_filter; | ^~~~~~~~ ../../trafficserver/plugins/experimental/traffic_dump/session_data.h:36:1: note: ‘std::optional’ is defined in header ‘<optional>’; did you forget to ‘#include <optional>’? 35 | #include "tscore/ts_file.h" +++ |+#include <optional> 36 | In file included from ../../trafficserver/plugins/experimental/traffic_dump/transaction_data.cc:29: ../../trafficserver/plugins/experimental/traffic_dump/session_data.h:110:15: error: ‘optional’ in namespace ‘std’ does not name a template type 110 | static std::optional<IpAddr> client_ip_filter; | ^~~~~~~~ ../../trafficserver/plugins/experimental/traffic_dump/session_data.h:36:1: note: ‘std::optional’ is defined in header ‘<optional>’; did you forget to ‘#include <optional>’? 35 | #include "tscore/ts_file.h" +++ |+#include <optional> 36 | . . . . . . -- Randall DuCharme (Radio AD5GB) Powered entirely by Open Source software.
-- Randall DuCharme (Radio AD5GB) Powered entirely by Open Source software.
OpenPGP_0x4BC19D71C1381AA3.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
