> > void TSHttpTxnResponseActionSet(TSHttpTxn txnp, TSResponseAction action); - > I still don't like passing the action by value.
Yes, it's a pointer now. Sorry, I changed the code, forgot to update the PR description: https://github.com/apache/trafficserver/blob/f22e1c/src/traffic_server/InkAPI.cc#L10039 void TSHttpTxnResponseActionSet(TSHttpTxn txnp, TSResponseAction *action); On Thu, Mar 4, 2021 at 3:18 PM Alan Carroll <solidwallofc...@verizonmedia.com.invalid> wrote: > > > > I think you noted that TSHostnameIsSelf(const char *hostname) is painful > > to make take a non-null terminated string. Is that still the case? > > > void TSHttpTxnResponseActionSet(TSHttpTxn txnp, TSResponseAction action); - > I still don't like passing the action by value. >
