Greetings, Seems the latest commits to master have broken the build. It terminates with:
.. CXX experimental/memory_profile/memory_profile_la-memory_profile.lo CXX experimental/metalink/metalink.lo ../../trafficserver/plugins/experimental/maxmind_acl/mmdb.cc:540:6: error: out-of-line definition of 'eval_ip' does not match any declaration in 'Acl' Acl::eval_ip(const sockaddr *sock) const ^~~~~~~ ../../trafficserver/plugins/experimental/maxmind_acl/mmdb.h:107:11: note: member declaration does not match because it is not const qualified ipstate eval_ip(const sockaddr *sock); ^ ~ CXX experimental/money_trace/money_trace.lo 1 error generated. make[2]: *** [Makefile:5823: experimental/maxmind_acl/mmdb.lo] Error 1 make[2]: *** Waiting for unfinished jobs.... This seems to make it happy: diff --git a/plugins/experimental/maxmind_acl/mmdb.h b/plugins/experimental/maxmind_acl/mmdb.h index 828ffe3bf..561b42f49 100644 --- a/plugins/experimental/maxmind_acl/mmdb.h +++ b/plugins/experimental/maxmind_acl/mmdb.h @@ -104,5 +104,5 @@ protected: void loadhtml(YAML::Node htmlNode); bool eval_country(MMDB_entry_data_s *entry_data, const char *path, int path_len); void parseregex(YAML::Node regex, bool allow); - ipstate eval_ip(const sockaddr *sock); + ipstate eval_ip(const sockaddr *sock) const; }; Should I submit another PR or has someone else got this? I didn't see anything pending in PRs or issues on the hub. Best! -- Randall DuCharme (Radio AD5GB) Powered by Open Source software.
0x4BC19D71C1381AA3.asc
Description: application/pgp-keys
signature.asc
Description: OpenPGP digital signature
