You can take a look at this pr https://github.com/apache/trafficserver/pull/6015 The short version is, there is a thread that checks a bunch of config files that has changed, it loops every second if I remember correctly. And there was a flag that was removed in a cleanup pr, which resulted in this thread not just checking, but also triggering a reload if there's any changes made to those config files.
On Mon, Oct 14, 2019 at 11:36 AM Sudheer Vinukonda <sudheervinuko...@yahoo.com.invalid> wrote: > Yes, improving "traffic_ctl config status" to show more context sounds > great. > But, tbh, I'm not quite sure to understand why/how that's tied to the > issue of automatic reloading of "remap.config". > The latter sounds like a regression and I think we should focus on fixing > it rather than on removing pre-existing features? (I believe "traffic_ctl > config status" existed from release 6 at the very least, if not longer). > My 2c.. > Thanks, > Sudheer > On Monday, October 14, 2019, 09:27:18 AM PDT, Fei Deng < > duke8...@apache.org> wrote: > > Seems like there's some use to it, maybe we should change it to display > which configs are being modified, instead of just saying yes/no? > > On Fri, Oct 11, 2019 at 8:42 AM Emanuele Rocca <e...@wikimedia.org> wrote: > > > Hello! > > > > On 10/10 03:34, Fei Deng wrote: > > > While fixing the problem where "remap.config" gets reloaded > > automatically, > > > we noticed it is related to the command "traffic_ctl config status". > Some > > > of us at the summit thinks that this command isn't useful, since the > only > > > thing it does is returning a status code to say some config files has > > been > > > changed and a "traffic_ctl config reload" is required to make those > > changes > > > take effect. However, it does NOT show which of the config files has > been > > > changed. > > > > There are also config changes that require a restart to be applied, and > > traffic_ctl config status does detect those. We are using it in a > > monitoring check [1] and find it quite useful, so unless there are > > specific issues with it (or there's an alternative), -1 from our side. > > > > [1] > > > https://github.com/wikimedia/puppet/blob/production/modules/profile/files/trafficserver/check_trafficserver_config_status.sh > > >
