You should approve #4738 so I can merge that, then make a PR for the configuration along with updated documentation. Thanks!
On Thu, Jan 10, 2019 at 1:24 PM CrazyCow <zhangzizhong0...@gmail.com> wrote: > Thanks for the info. I'll add the missing entry. > > Susan Hinrichs <shinr...@apache.org> 于2019年1月10日周四 上午9:32写道： > > > Looks like the request_buffer_enabled was added by zizhong. > > 78cb6c9bf86e8d72c79a9084604bc25520ef57d7 > > > > If there is no RecordsConfig.cc entry does that mean it is override only? > > > > On Thu, Jan 10, 2019 at 11:10 AM Alan Carroll > > <solidwallofc...@oath.com.invalid> wrote: > > > > > During some documentation build repair (#4783) I came upon this > > overridable > > > configuration. What is odd is that there is no entry in > > "RecordsConfig.cc" > > > for it. I had to guess what it did from the code, so if anyone knows > what > > > this is supposed to do, either do a doc fix PR or let me know. More > > > importantly, is this lack of a records.config value by design, or an > > > oversight? It doesn't seem a valid situation to me. > > > > > > -- > > > *Beware the fisherman who's casting out his line in to a dried up > > > riverbed.* > > > *Oh don't try to tell him 'cause he won't believe. Throw some bread to > > the > > > ducks instead.* > > > *It's easier that way. *- Genesis : Duke : VI 25-28 > > > > > > -- *Beware the fisherman who's casting out his line in to a dried up riverbed.* *Oh don't try to tell him 'cause he won't believe. Throw some bread to the ducks instead.* *It's easier that way. *- Genesis : Duke : VI 25-28
