Re: [API] Proposal for new TLS hooks on outbound connection and accessor functions

[Steven R. Feltner]

I've browsed through the PR, and I see where you've used the proposed hooks in 
ssl_hook_test.cc, but I am missing what the use case for these hooks would be.  
Can you elaborate a bit?

Thanks,
Steven

On 10/9/18, 4:12 PM, "Susan Hinrichs" <shinr...@oath.com.INVALID> wrote:

    I am proposing changes to enable a plugin to access the outbound SSL object
    and override elements as it likes before the outgoing TLS handhake
    completes.
    
    To acheive this, I have put up PR #4377, which adds the following hooks
    * TS_VCONN_OUTBOUND_START_HOOK
    * TS_VCONN_OUTBOUND_CLOSE_HOOK
    These are analogous to the TS_VCONN_START_HOOK and TS_VCONN_CLOSE hook,
    except that they apply to the outbound connections instead of the inbound
    connections.  The START hook can be delayed and restarted.  The CLOSE hooks
    must be reenabled immediately.  The callback is given the TSVConn of the
    outbound connection.
    
    In addition, I propose the following new Plugin APIs to fetch continuation
    that requested the new outbound connection
    
    * TSCont TSNetInvokingContGet(TSVConn conn)
    
    * TSHttpTxn TSNetInvokingTxnGet(TSVConn conn)
    
    
    Please review and share your thoughts.
    
    
    Thanks,
    
    Susan