> On Aug 7, 2018, at 3:24 PM, Pushkar Pradhan <pprad...@oath.com.INVALID> wrote:
>
> Hi Leif,
> I usually do one feature/fix per PR but do have multiple commits.
> Would it easier if we squash the commits into one and then create the PR?
Right, this proposal is saying that whereas before we recommended squashing,
but allowed multiple commits, we now *require* that you either:
1) Squash all commits into one commit, and one PR
2) Break the commits out into multiple PRs
#2 is still a viable option, in particular for large projects where it’s
natural to have multiple commits. Reviewing multiple, smaller PRs, is generally
easier than one big commit. Yes, it kinda sucks that we can’t do multiple
commits in a single PR, but Github is seriously broken in this regard (you
can’t treat a PR as a single atomic unit when it has multiple commits :-/).
Note that we still require all commits to always be stable and build. I.e. you
*must* always squash commits that you’ve made while working, and not make a PR
which has commits which might break builds, or not function.
Cheers,
— leif
