+1 On Sat, 12 May 2018 at 12:35, Bryan Call <bc...@apache.org> wrote:
> +1 > > -Bryan > > > On May 10, 2018, at 4:02 PM, Chris Lemmons <alfic...@gmail.com> wrote: > > > > The PR is here: https://github.com/apache/trafficserver/pull/3638 > > > > This is an API change, so I'm bringing it up. Previously, these > > functions were returning -1 in an unsigned type: size_t. They got > > these size_t values from regular integers, ensuring that not only was > > an oversized type misleading callers, they were encouraged to check > > unsigned values for negative results. > > > > I've updated the internal functions so that they use size_t > > consistently. That part is just a bug fix and does not break the API. > > > > I've also changed the return type from size_t to ssize_t. This > > "breaks" the API, but I think it's probably ok. What do y'all think? > >
