Thanks, Alan. Yes, TSHttpTxnPostBufferReaderGet seems better to me. It's more consistent with existing ones and more descriptive about the functionality.
Bryan, what do you think? 2018-03-07 12:34 GMT-08:00 Alan Carroll <solidwallofc...@oath.com.invalid>: > Seems reasonable, except maybe `TSHttpTxnPostBufferReaderGet()`? Most of > the API that takes a TSHttpTxn is prefixed with 'TSHTTPTxn'. > > On Wed, Mar 7, 2018 at 11:15 AM, Bryan Call <bc...@apache.org> wrote: > > > +1 > > > > -Bryan > > > > > > > > > On Mar 5, 2018, at 11:19 AM, CrazyCow <zhangzizhong0...@gmail.com> > > wrote: > > > > > > Hi, Team, > > > > > > Along with the post buffer PR > > > <https://github.com/apache/trafficserver/pull/2335> which buffers post > > body > > > before opening connections to origin servers, I'd introduce a new API > > that > > > enables plugins to read the buffered body. > > > > > > TSIOBufferReader TSIOBufferReaderPostGet(TSHttpTxn txnp); > > > > > > > > > Plugins can read the entire post body via the returned > TSIOBufferReader. > > > > > > > > > Please let me know what you think about this new API. Any idea would be > > > much appreciated! > > > > > > > > > Thanks, > > > Zizhong > > > > >
