+1 on TSFatal(). We already have Fatal() in the code. -Bryan
> On Feb 16, 2018, at 7:33 AM, Alan Carroll <solidwallofc...@oath.com.INVALID> > wrote: > > PR 3129 was a fix to the ICC builds that disables a "expression is > constant" error which resulted from code that looks like > > TSReleaseAssert(!"error message") > > The goal of this code is to (1) force a process shut down and (2) with a > specific error message. We discussed some alternatives and the one I liked > best is to add a TS API function something like "TSPanic" or "TSFatal" > which works like the assert but always aborts. This might make the code / > intention a bit clearer as not everyone is familiar with this particular > paradigm. Any suggestions or comments on the naming of this function? I > prefer "TSFatal" myself.
