One of the things that was accomplished at the ATS Summits over the past several days (in addition to clearing up many many Coverity issues) was getting the build system integration with GitHub fixed up. We now have real commit status updates from Jenkins so all those ugly comments are gone. We were actually getting rate limited by GitHub and it brought our build system to a crawl. We've required all these builds status to be passing before the PR can be merge. So no more accidental merges or getting confused by all the comments from Jenkins.
Which brings me to the reason for this email. We are also trying out requiring reviews. So now you have to have one positive review for a PR to be mergeable. This even applies to docs, sorry Miles. This means that we need to do a better job of reviewing, and when we review we need to actually respond with an approval review. If you have specific things you'd like to see fixed, leave a changes requested review. This will give clear feedback to the author on what steps they need to take to get the PR approved. This puts more onus on the reviewer, but I think it will help out in the long run. We really need to have everyone participate. You can filter PRs by ones without a review, and also by ones awaiting review from you. Please try and start doing a few reviews a week. I know I have to get better at this too. Thanks.
