Thank you for all the feedback on this proposal. SOCKS support will stay in 7.0.0.
-Bryan > On Aug 26, 2016, at 2:19 AM, Chao Xu <xuc...@gmail.com> wrote: > > Hi Bryan Call, > > I will handle the socks issues and make it works again. > > There are 2 socks features as following: > 1. as socks client, ATS will connect to parent server and origin server via > socks server > > minimum configuration: > proxy.config.socks.socks_needed INT 1 > proxy.config.socks.default_servers STRING x.x.x.x:1080 x.x.x.x:1080 > x.x.x.x:1080 > proxy.config.socks.socks_version INT 4 (default) > proxy.config.socks.socks_config_file STRING socks.config (default) > > 2. as socks proxy, ATS will identify HTTP request on tcp port 80 and the > rest of requests will proxy to socks server > minimum configuration: > proxy.config.socks.socks_needed INT 1 > proxy.config.socks.accept_enabled INT 1 > proxy.config.socks.accept_port INT 1080 (default) > proxy.config.socks.http_port INT 80 (default) > > The socks proxy feature requires enalbing socks client feature first. > > > > 2016-08-24 0:45 GMT+08:00 Bryan Call <bc...@apache.org>: > >> The reasons to remove it would be if it is broken ( >> https://issues.apache.org/jira/browse/TS-2482 <https://issues.apache.org/ >> jira/browse/TS-2482>) or if no one is using it (most code requires some >> maintenance). >> >> If people are using it and want to keep it then please speak up and vote >> on keeping it. If you are willing to fix bugs on the feature than that is >> even better! >> >> -Bryan >> >> >> >> >>> On Aug 23, 2016, at 2:04 AM, Chao Xu <xuc...@gmail.com> wrote: >>> >>> I have do some analysis on socks proxy code, It is a very simple ProxySM. >>> It is a good start for a newbie to be a ATS developer. >>> >>> Why do we remove it if it doesn't bother us. >>> >>> Currently, I'm rewriting it into SocksProfileSM to verify the design of >>> ProfileSM. >>> >>> I draw two diagrams of socks proxy functions. >>> https://drive.google.com/open?id=0B6FSuL4tHtSHb2o2dnNTdXNMN0E >>> https://drive.google.com/open?id=0B6FSuL4tHtSHTDFESl9RWmNjQkU >>> >>> >>> 2016-08-22 22:38 GMT+08:00 James Peach <jpe...@apache.org>: >>> >>>> >>>>> On Aug 22, 2016, at 3:40 AM, Chao Xu <xuc...@gmail.com> wrote: >>>>> >>>>> The Socks Proxy feature is used to route HTTP request in socks request >> to >>>>> HttpSM and Tunnel non-Http request to Socks Server. >>>>> >>>>> It is a Socks Proxy and it is NOT the replacement of Socks Server. >>>> >>>> I've never heard on anyone even trying to use our Socks code, but maybe >> we >>>> should take some extra time to study it. Do you think there is value in >>>> keeping it? >>>> >>>>> 2016-08-21 10:04 GMT+08:00 James Peach <jpe...@apache.org>: >>>>> >>>>>> >>>>>>> On Aug 19, 2016, at 11:33 AM, Bryan Call <bc...@apache.org> wrote: >>>>>>> >>>>>>> There are a few features we are looking to remove in the ATS 7.0.0 >>>>>> release. If you are using these features and require them, please >>>> respond >>>>>> to this email. We also need to have people that are willing to invest >>>> time >>>>>> and fix some of the bugs for these features. Your feedback is very >>>>>> important! >>>>>>> >>>>>>> SOCKS is a feature that hasn’t had a lot of usage and support on it. >>>> It >>>>>> would be helpful to know who is using it and willing to fix bugs on >> it. >>>>>>> >>>>>>> The proposal is to remove the configurations options, statistics, and >>>>>> code for SOCKS. >>>>>> >>>>>> +1 I don’t think anyone is getting much value out of our SOCKS code. >>>>>> >>>>>> J >>>> >>>> >> >>
