Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/751
This seems good, +1.
One comment, as discussed on the IRC:
It seems unfortunate that we have two state variables (closed=true, and the
_state= HTTP2_STREAM_STATE_CLOSED for H2) indicating the same state. It seems
that we ended up with this bug because we set the closed=true, but forgot to
update the _state.
At a minimum, maybe we should add some strategic ink_assert() in places
where these two can get obviously out of sync?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
