Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/749#discussion_r68776903
--- Diff: proxy/http/HttpTransact.cc ---
@@ -8199,13 +8199,15 @@ HttpTransact::build_error_response(State *s,
HTTPStatus status_code, const char
if (has_ua_msie)
s->hdr_info.client_response.value_set(MIME_FIELD_PROXY_CONNECTION,
MIME_LEN_PROXY_CONNECTION, "close", 5);
}
- // Add a bunch of headers to make sure that caches between
- // the Traffic Server and the client do not cache the error
- // page.
+ // Make sure that caches between the Traffic Server and the client do
not cache the error.
+ // ToDo: Not sure this matches expectation in RFC 7223.
--- End diff --
Well, I'm open to suggestion here. It seems, as per the RFC, that we
probably shouldn't modify the Cache-Control header here? That seems inline with
the code build_response() function too, right ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
