Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/738#discussion_r68441181
--- Diff: plugins/experimental/remap_stats/remap_stats.c ---
@@ -92,19 +92,20 @@ stat_add(char *name, TSMgmtInt amount,
TSStatPersistence persist_type, TSMutex c
static char *
get_effective_host(TSHttpTxn txn)
{
- char *effective_url, *tmp;
const char *host;
int len;
TSMBuffer buf;
TSMLoc url_loc;
+ char *effective_url, *tmp;
--- End diff --
Why has this changed places? I don't think we should introduce changes that
don't make things better. This is effectively a net zero change and I don't
think we should make it. It just makes diff's harder to read.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
