Github user SolidWallOfCode commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/704#discussion_r66988505
  
    --- Diff: iocore/hostdb/HostDB.cc ---
    @@ -2224,13 +2227,14 @@ put_hostinfo_ClusterFunction(ClusterHandler *ch, 
void *data, int /* len ATS_UNUS
     int
     HostDBContinuation::backgroundEvent(int /* event ATS_UNUSED */, Event * /* 
e ATS_UNUSED */)
     {
    -  ++hostdb_current_interval;
    +  // No nothing if hosts file checking is not enabled.
    +  if (hostdb_hostfile_check_interval == 0) {
    +    return EVENT_CONT;
    --- End diff --
    
    Shouldn't this be `EVENT_DONE`? Because it's done, there is no continuing 
operation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to