Github user jacksontj commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/653#discussion_r66097455
  
    --- Diff: lib/ts/ink_res_init.cc ---
    @@ -503,7 +503,20 @@ ink_res_init(ink_res_state statp,         ///< State 
object to update.
               hints.ai_family = PF_UNSPEC;
               hints.ai_socktype = SOCK_DGRAM; /*dummy*/
               hints.ai_flags = AI_NUMERICHOST;
    -          sprintf(sbuf, "%d", NAMESERVER_PORT);
    +
    --- End diff --
    
    I started looking around-- and it seems like that would work-- but I can't 
quite get it to work. `ats_ip_parse` gives me back a string, where I really 
want a sockaddr-- but when i use `ats_ip_pton` it doesn't seem to work for me-- 
either way this is how it was done, so IMO shouldn't be blocking-- although it 
would be good to clean that up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to