Github user SolidWallOfCode commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/631#discussion_r65959288
  
    --- Diff: iocore/hostdb/HostDB.cc ---
    @@ -1998,6 +1988,19 @@ HostDBContinuation::do_dns()
           hostdb_cont_free(this);
           return;
         }
    +    ts::ConstBuffer hname(md5.host_name, md5.host_len);
    +    Ptr<RefCountedHostsFileMap> current_host_file_map = 
hostDB.hosts_file_ptr;
    +    HostsFileMap::iterator find_result = 
current_host_file_map->hosts_file_map.find(hname);
    +    if (find_result != current_host_file_map->hosts_file_map.end()) {
    +      if (action.continuation) {
    +        // Set the TTL based on how much time remains until the next sync
    +        HostDBInfo *r = lookup_done(IpAddr(find_result->second), 
md5.host_name, false,
    +                                    current_host_file_map->next_sync_time 
- Thread::get_hrtime(), NULL);
    --- End diff --
    
    Isn't that value to `lookup_done` TTL in seconds, not nanoseconds?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to