Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r65651918
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -583,7 +468,7 @@ reply_to_cont(Continuation *cont, HostDBInfo *r, bool
is_srv = false)
ink_assert(!"missing hostname");
cont->handleEvent(is_srv ? EVENT_SRV_LOOKUP : EVENT_HOST_DB_LOOKUP,
NULL);
Warning("bogus entry deleted from HostDB: missing hostname");
- hostDB.delete_block(r);
+ hostDB.newCache->del(r->key);
--- End diff --
I have to agree with HRP - we should hold to STL conventions where
possible, so this should be `erase`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
