Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r64921978
--- Diff: proxy/http/HttpTransact.h ---
@@ -905,8 +905,9 @@ class HttpTransact
int next_hop_scheme; // out
int orig_scheme; // pre-mapped scheme
int method;
- int cause_of_death_errno; // in
- HostDBInfo host_db_info; // in
+ int cause_of_death_errno; // in
+ Ptr<RefCountCacheItem<HostDBInfo>> *hostdb_entry; // Pointer to the
entry we are referencing in hostdb-- to keep our ref
--- End diff --
``hostdb_entry`` doesn't need to be allocated, it should be
``Ptr<RefCountCacheItem<HostDBInfo>>``. Consider making a typedef for
``RefCountCacheItem<HostDBInfo>`` to reduce the verbosity.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
