Github user SolidWallOfCode commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/634#discussion_r63216314
  
    --- Diff: proxy/InkAPI.cc ---
    @@ -8175,471 +8177,163 @@ TSHttpTxnConfigStringGet(TSHttpTxn txnp, 
TSOverridableConfigKey conf, const char
       return TS_SUCCESS;
     }
     
    +struct TXN_CONFIG_PAIR {
    +  TSOverridableConfigKey cnf;
    +  TSRecordDataType typ;
    +  TXN_CONFIG_PAIR(TSOverridableConfigKey cnf = TS_CONFIG_NULL, 
TSRecordDataType typ = TS_RECORDDATATYPE_INT)
    +  {
    +    this->cnf = cnf;
    +    this->typ = typ ? typ : TS_RECORDDATATYPE_INT;
    +  };
    +};
    +
    +std::unordered_map<std::string, TXN_CONFIG_PAIR>
    --- End diff --
    
    Why static? Do you mean in the anonymous namespace to avoid linkage 
visibility?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to