Github user jacksontj commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/564#discussion_r59737621
--- Diff: lib/ts/ink_inet.cc ---
@@ -307,6 +307,26 @@ ats_ip_hash(sockaddr const *addr)
return zret.i;
}
+uint64_t
+ats_ip_port_hash(sockaddr const *addr)
+{
+ union md5sum {
+ uint64_t i;
+ uint16_t b[4];
+ unsigned char c[16];
+ } zret;
+
+ zret.i = 0;
+ if (ats_is_ip4(addr)) {
+ zret.i = (static_cast<uint64_t>(ats_ip4_addr_cast(addr)) << 16) |
(ats_ip_port_cast(addr));
+ } else if (ats_is_ip6(addr)) {
+ ink_code_md5(const_cast<uint8_t *>(ats_ip_addr8_cast(addr)),
TS_IP6_SIZE, zret.c);
+ // now replace the bottom 16bits so we can account for the port.
+ zret.b[3] = ats_ip_port_cast(addr);
--- End diff --
It seems that this returns nothing/garbage in the ipv6 case-- as both lines
in ipv6 simply add to `.b` and `.c`, but the method only returns `.i`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
