Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/430#discussion_r50420560
--- Diff: proxy/hdrs/URL.cc ---
@@ -1264,7 +1287,7 @@ url_parse_internet(HdrHeap *heap, URLImpl *url, char
const **start, char const *
last_colon = 0; // prevent port setting.
}
}
- if (host._size)
+ if (host._size && validate_host_name(host))
--- End diff --
I think here the condition should be to check `host._size` first and then
for `validate_host_hdr` either set the host (if success) or generate an error
(if false). It is acceptable to not have a host at all in the URL, but it is
unacceptable (an error) if there is a host and it's malformed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
