Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/374#discussion_r48355620
--- Diff: iocore/net/SSLNetVConnection.cc ---
@@ -1400,10 +1416,9 @@ SSLNetVConnection::select_next_protocol(SSL *ssl,
const unsigned char **out, uns
void
SSLNetVConnection::reenable(NetHandler *nh)
{
- if (this->sslPreAcceptHookState != SSL_HOOKS_DONE) {
- this->sslPreAcceptHookState = SSL_HOOKS_INVOKE;
- this->readReschedule(nh);
- } else {
+ if (sslPreAcceptHookState != SSL_HOOKS_DONE) {
+ sslPreAcceptHookState = SSL_HOOKS_INVOKE;
+ } else if (sslHandshakeHookState == HANDSHAKE_HOOKS_INVOKE) {
// Reenabling from the handshake callback
--- End diff --
I'll try to play with this patch over break. As I recall the
readReschedule was necessary to deal with multi-thread processing. But I could
be mis-remembering. Or cleaning up the state transitions may have eliminated
that problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
